Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e_antic 2.0.2, normaliz 3.10.3, pynormaliz 2.20, polymake 4.12 #38140

Merged
merged 8 commits into from
Jun 22, 2024
Merged

e_antic 2.0.2, normaliz 3.10.3, pynormaliz 2.20, polymake 4.12 #38140

merged 8 commits into from
Jun 22, 2024

Conversation

mkoeppe
Copy link

@mkoeppe mkoeppe commented Jun 2, 2024 •
edited
Loading

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Jun 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 7354baf; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe added this to the sage-10.4 milestone Jun 6, 2024
@mkoeppe mkoeppe requested a review from tscrim June 6, 2024 06:23
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 10, 2024
sagemathgh-38140: e_antic 2.0.2, normaliz 3.10.3, pynormaliz 2.20, po…
6b741c0 
…lymake 4.12

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- https://polymake.org/doku.php/news/release_4_12

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#38144 (merged here
for testing)
    
URL: sagemath#38140
Reported by: Matthias Köppe
Reviewer(s):
tscrim
tscrim approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the bots come back clean, positive review.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
sagemathgh-38140: e_antic 2.0.2, normaliz 3.10.3, pynormaliz 2.20, po…
a0d9c2c 
…lymake 4.12

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- https://polymake.org/doku.php/news/release_4_12

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#38144 (merged here
for testing)
    
URL: sagemath#38140
Reported by: Matthias Köppe
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
sagemathgh-38140: e_antic 2.0.2, normaliz 3.10.3, pynormaliz 2.20, po…
647a39b 
…lymake 4.12

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- https://polymake.org/doku.php/news/release_4_12

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#38144 (merged here
for testing)
    
URL: sagemath#38140
Reported by: Matthias Köppe
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit 16452c2 into sagemath:develop Jun 22, 2024
13 of 33 checks passed
@mkoeppe mkoeppe deleted the pynormaliz-2.20 branch June 22, 2024 20:17
@mkoeppe
Copy link
Author

mkoeppe commented Jun 23, 2024

@vbraun Missing on mirrors: PyNormaliz-2.20.tar.gz
https://github.com/sagemath/sage/actions/runs/9627865229/job/26555448129#step:5:1390

@mkoeppe
Copy link
Author

mkoeppe commented Jun 23, 2024

Actually my mistake, fixed in #38260

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 26, 2024
sagemathgh-38260: build/pkgs/pynormaliz: Fix tarball name, version_…
19bd202 
…requirements.txt

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixes a mistake made in the update sagemath#38140

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

URL: sagemath#38260
Reported by: Matthias Köppe
Reviewer(s): Travis Scrimshaw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: packages: optional v: small
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mkoeppe @tscrim @vbraun @kwankyu